Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding alb as a gateway type #118

Merged
merged 3 commits into from
Jan 27, 2023
Merged

adding alb as a gateway type #118

merged 3 commits into from
Jan 27, 2023

Conversation

jhsinger-klotho
Copy link
Contributor

@jhsinger-klotho jhsinger-klotho commented Jan 20, 2023

• Does any part of it require special attention?
• Does it relate to or fix any issue?

closes #109

Adding ALB as a type for expose, which will work with lambda and EKS today (ECS still hardcodes NLBs in the code of the compiler so we need some serious cleanup there.

We add our public subnets to our SG so we can enable the delivery of ALB requests to our backend (These are the private cidr blocks of those subnets)

Because i went down the route of Websocket APIs first i had refactored the APIGateway class to use the LB Plugin in a similar manner. I would have to back out a lot of changes to deploy lib and the index.ts.tmpl file to get the ALB Functionality to work and remove the web socket funcitonality.

The web socket functionality does allow us to create a websocket API GW and a single exec, but isnt too useable outside of that. Cut #117 to dive into that more

Also modularizes all the API Gateway code out of deploylib as a part of these changes.

Standard checks

  • Unit tests: Any special considerations? changed the provider unit test, will change some integ tests to
  • Docs: Do we need to update any docs, internal or public? https://github.com/klothoplatform/docs/pull/152
  • Backwards compatibility: Will this break existing apps? If so, what would be the extra work required to keep them working? yes, this is a new type, i do not believe our IaC should have anything which is not backwards compatible but our logic is very use case based which isnt great (We talked about it in sync and the need to move it to the compiler)

needsGatewayLink = true
}
})
console.log(needsLoadBalancer)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this old debug?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yes, need to remove. I also need to add the topology image i realized.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

topology is kind of blocked, i cut klotho #111 so we can discuss and fix it

@github-actions
Copy link

Package Line Rate Health
github.com/klothoplatform/klotho/pkg/analytics 2%
github.com/klothoplatform/klotho/pkg/annotation 23%
github.com/klothoplatform/klotho/pkg/cli 4%
github.com/klothoplatform/klotho/pkg/core 20%
github.com/klothoplatform/klotho/pkg/env_var 82%
github.com/klothoplatform/klotho/pkg/exec_unit 45%
github.com/klothoplatform/klotho/pkg/infra/kubernetes 59%
github.com/klothoplatform/klotho/pkg/infra/kubernetes/helm 39%
github.com/klothoplatform/klotho/pkg/input 63%
github.com/klothoplatform/klotho/pkg/lang 37%
github.com/klothoplatform/klotho/pkg/lang/dockerfile 0%
github.com/klothoplatform/klotho/pkg/lang/golang 9%
github.com/klothoplatform/klotho/pkg/lang/javascript 47%
github.com/klothoplatform/klotho/pkg/lang/python 60%
github.com/klothoplatform/klotho/pkg/lang/yaml 0%
github.com/klothoplatform/klotho/pkg/logging 7%
github.com/klothoplatform/klotho/pkg/multierr 95%
github.com/klothoplatform/klotho/pkg/provider/aws 59%
github.com/klothoplatform/klotho/pkg/runtime 75%
github.com/klothoplatform/klotho/pkg/static_unit 32%
github.com/klothoplatform/klotho/pkg/validation 73%
github.com/klothoplatform/klotho/pkg/yaml_util 79%
Summary 40% (3696 / 9350)

@jhsinger-klotho jhsinger-klotho merged commit 587aa1c into main Jan 27, 2023
@jhsinger-klotho jhsinger-klotho deleted the websocket branch January 27, 2023 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support websocket APIs for EKS Through ALBs
2 participants