-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding alb as a gateway type #118
Conversation
pkg/infra/pulumi_aws/iac/eks.ts
Outdated
needsGatewayLink = true | ||
} | ||
}) | ||
console.log(needsLoadBalancer) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this old debug?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah yes, need to remove. I also need to add the topology image i realized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
topology is kind of blocked, i cut klotho #111 so we can discuss and fix it
|
• Does any part of it require special attention?
• Does it relate to or fix any issue?
closes #109
Adding ALB as a type for expose, which will work with lambda and EKS today (ECS still hardcodes NLBs in the code of the compiler so we need some serious cleanup there.
We add our public subnets to our SG so we can enable the delivery of ALB requests to our backend (These are the private cidr blocks of those subnets)
Because i went down the route of Websocket APIs first i had refactored the APIGateway class to use the LB Plugin in a similar manner. I would have to back out a lot of changes to deploy lib and the index.ts.tmpl file to get the ALB Functionality to work and remove the web socket funcitonality.
The web socket functionality does allow us to create a websocket API GW and a single exec, but isnt too useable outside of that. Cut #117 to dive into that more
Also modularizes all the API Gateway code out of deploylib as a part of these changes.
Standard checks