Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes python fs and adds basic support for file modes #107

Merged
merged 1 commit into from
Jan 18, 2023

Conversation

DavidSeptimus-Klotho
Copy link
Contributor

This PR fixes python persist fs support for reading files and adds basic support for file modes to enable use with binary or text files.

The "a" mode flag (append) is unsupported.

Standard checks

  • Unit tests: Any special considerations? N/A
  • Docs: Do we need to update any docs, internal or public? we should probably document supported/unsupported flags
  • Backwards compatibility: Will this break existing apps? If so, what would be the extra work required to keep them working?

The "a" mode flag (append) is unsupported
@github-actions
Copy link

Package Line Rate Health
github.com/klothoplatform/klotho/pkg/analytics 2%
github.com/klothoplatform/klotho/pkg/annotation 23%
github.com/klothoplatform/klotho/pkg/core 20%
github.com/klothoplatform/klotho/pkg/env_var 82%
github.com/klothoplatform/klotho/pkg/exec_unit 45%
github.com/klothoplatform/klotho/pkg/infra/kubernetes 58%
github.com/klothoplatform/klotho/pkg/infra/kubernetes/helm 52%
github.com/klothoplatform/klotho/pkg/input 63%
github.com/klothoplatform/klotho/pkg/lang 37%
github.com/klothoplatform/klotho/pkg/lang/dockerfile 0%
github.com/klothoplatform/klotho/pkg/lang/golang 9%
github.com/klothoplatform/klotho/pkg/lang/javascript 47%
github.com/klothoplatform/klotho/pkg/lang/python 60%
github.com/klothoplatform/klotho/pkg/lang/yaml 0%
github.com/klothoplatform/klotho/pkg/logging 7%
github.com/klothoplatform/klotho/pkg/multierr 95%
github.com/klothoplatform/klotho/pkg/provider/aws 60%
github.com/klothoplatform/klotho/pkg/runtime 75%
github.com/klothoplatform/klotho/pkg/static_unit 32%
github.com/klothoplatform/klotho/pkg/validation 73%
Summary 42% (3594 / 8621)

@DavidSeptimus-Klotho DavidSeptimus-Klotho merged commit 40eba0c into main Jan 18, 2023
@DavidSeptimus-Klotho DavidSeptimus-Klotho deleted the python-fs-fix branch January 18, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant