-
-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added data-tag attribute to passageCard #1493
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR! I have some suggestions on revisions. If you have followup questions, feel free to ask.
@rubynguyen1510 looks good now, but one last question before I merge: any reason you used |
Thanks for your feedback! We overlooked the plural naming convention. Just fixed it! |
@rubynguyen1510 almost there, I think! |
Looks good--thanks for your work! |
Description
Issues Fixed
#1438
Testing
In the development of our test to validate the data-tags attribute on the passage card, we evaluated two potential selection methods. They were 'getByTestId' and 'getByText'.
getByTestID
const passageElement = screen.getByTestId('passage-card');
getByText
const passageElement = screen.getByText(passage.name).closest('.passage-card');
We chose getByTestId over getByText because it is more reliable, and efficient and could be used to specifically target the passage card element.
Test Results
Credit
[X] We would like to be credited in the application as Siham Argaw and Ngoc Nguyen.
Presubmission Checklist
[X] We have read this project's CONTRIBUTING file, and this PR follows the criteria laid out there.
[X] This contribution was created by us and we have the right to submit it under the GPL v3 license. (This is not a rights assignment.)
[X] We have read and agree to abide by this project's Code of Conduct.