Added dependency for travis-cli. #253
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joakimbeng
requested changes
Dec 19, 2018
There was a problem hiding this comment.
I don't know why this PR haven't triggered a Travis build but if it would it would fail, because the commit message does not follow the Conventional Commit guidelines.
Also, when setting the script for Travis you must add the default commands manually, i.e. npm test must be added after the commitlint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@joakimbeng If this PR needs any changes or edits, just let me know and I'll fix it accordingly.
This PR is for #252.
Added dependency for travis-cli to package.json.
Added logic to run linter in .travis.yml.