Remove old navigation listeners when reloading #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good find. Chrome dev tools confirmed the bug (unbounded growth in event listeners after HMR):
And after your fix:
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reloading, the old popstate/hashchange event listeners were not removed so every time you reloaded you got one extra event when navigating.
I don't know if this is related or not, but I had some issues where the virtual DOM got strange after a hot reload (essentially, parts of the DOM would be duplicated when navigating). A workaround for this was to make the top level nodes keyed. However, after removing the event listeners, I no longer experience this.