This repository was archived by the owner on Aug 19, 2024. It is now read-only.
Updated fetcher in order not to do useless jobs#787
Merged
KimKyungup merged 2 commits intoklaytn:devfrom Nov 30, 2020
Merged
Conversation
jeongkyun-oh
requested review from
KimKyungup,
aidan-kwon,
ehnuje,
joowon-byun,
kjhman21 and
yoomee1313
as code owners
ehnuje
reviewed
Nov 27, 2020
ehnuje
previously approved these changes
Nov 27, 2020
Co-authored-by: Melvin Junhee Woo <melvin.woo@groundx.xyz>
KimKyungup
approved these changes
Nov 27, 2020
Contributor
KimKyungup
left a comment
KimKyungup
left a comment
There was a problem hiding this comment.
This is not whole change of ethereum/go-ethereum#21263.
Will you apply all change of it?
If not, please note that you applied some part of the PR on the excel sheet. ^^
Contributor
Author
|
@KimKyungup Yes, I am planning to apply some others. Those PR is too big, so I dividing several ones. It is taking time to understand what PR contains. Anyway, I will update the spread sheet as well. |
ehnuje
approved these changes
Nov 27, 2020
yoomee1313
approved these changes
Nov 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
$ make test)