blockchain/asm: assembly parser label fixes#779
Conversation
|
Can this change make any incompatibility in Cypress? |
aidan-kwon
left a comment
There was a problem hiding this comment.
I think this change is okay. However, we should check the incompatibility the change may cause.
|
@aidan-kwon How can we check the possibility of incompatibility in Cypress? Sync the node from the genesis? |
@ehnuje It seems that |
KimKyungup
left a comment
There was a problem hiding this comment.
For now, Klaytn doesn't use this code.
Geth has evm cmd using this code. But it is not included makefile.
Anyway, let's merge this.
Proposed changes
Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
$ make test)Related issues
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...