This repository was archived by the owner on Aug 19, 2024. It is now read-only.
fixed possible datarace for downloader queue#749
Merged
jeongkyun-oh merged 2 commits intoklaytn:devfrom Nov 19, 2020
Merged
Conversation
yoomee1313
reviewed
Nov 18, 2020
Co-authored-by: Yumiel (yoomee1313) <yumiel.ko@groundx.xyz>
yoomee1313
approved these changes
Nov 19, 2020
Member
|
@jeongkyun-oh I cannot find any relation with ethereum/go-ethereum#21201. Indeed, the old code looks better for me. |
Contributor
Author
|
@aidan-kwon Sorry, it is related to 20690. The lock is acquired in each cancel function, which may cause data-race if other threads access the pending pool. The point is that the lock is acquired after reading |
KimKyungup
approved these changes
Nov 19, 2020
ehnuje
approved these changes
Nov 19, 2020
aidan-kwon
approved these changes
Nov 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
pendPoolread.Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
$ make test)