This repository was archived by the owner on Aug 19, 2024. It is now read-only.
downloader: measure successfull deliveries, not failed#1434
Merged
jeongkyun-oh merged 1 commit intoklaytn:devfrom Jun 17, 2022
Merged
downloader: measure successfull deliveries, not failed#1434jeongkyun-oh merged 1 commit intoklaytn:devfrom
jeongkyun-oh merged 1 commit intoklaytn:devfrom
Conversation
jeongkyun-oh
requested review from
KimKyungup,
ehnuje and
ethan-kr
as code owners
baerae-colin
approved these changes
Jun 16, 2022
aidan-kwon
approved these changes
Jun 17, 2022
ethan-kr
approved these changes
Jun 17, 2022
31 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
$ make test)