This repository was archived by the owner on Aug 19, 2024. It is now read-only.
fix use of *reflect.SliceHeader#1313
Merged
aidan-kwon merged 1 commit intoklaytn:devfrom Apr 11, 2022
Merged
Conversation
baerae-colin
approved these changes
Apr 9, 2022
baerae-colin
left a comment
There was a problem hiding this comment.
LGTM. those are not used in our production, though. :)
jeongkyun-oh
approved these changes
Apr 11, 2022
aidan-kwon
pushed a commit
to aidan-kwon/klaytn
that referenced
this pull request
Apr 19, 2022
fix use of *reflect.SliceHeader
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
go vetwarns the current use of *reflect.SliceHeader.The code is changed in more recommended way.
The rationale of this change: golang/go#40701
All changes in this PR are imported from ethereum/go-ethereum#21372 ethereum/go-ethereum#22696
Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
$ make test)