Strip dot git #864
Merged
Strip dot git #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only supported on Trusty in Travis CI.
Boolean option strip_dot_git in config.ini.
|
As this is optional, there shouldn't be problems when merging this PR. Did you check, if other components required further changes for generating the correct URLs? |
|
Hi, my analysis and tests at the time showed this was the centralized way to implement it, so no other modifications needed. |
|
@klaussilveira do you have any concerns on this PR? |
|
Nope, I think it is in good shape. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Anybody else bothered by the display of the .git extension of their bare repositories ?