Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zstd: Fix amd64 not always detecting corrupt data #785

Merged
merged 2 commits into from
Mar 22, 2023
Merged

zstd: Fix amd64 not always detecting corrupt data #785

merged 2 commits into from
Mar 22, 2023

Commits on Mar 22, 2023

  1. zstd: Fix amd64 not always detecting corrupt data 

    Fix undetected corrupt data in amd64 assembly.

In rare cases overreads would not get returned as errors, if a multiple of 256 bits was overread.
This would make the "bitsread" equal the expected 64.

Whenever all bytes has been read from memory we start checking if more than 64 bits has been read on every fill. This ensures that an overflow can never occur.

No invalid memory was accessed, this is merely a question if errors are reported.

Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=57290
    @klauspost
    klauspost committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    19baf95 View commit details
    Browse the repository at this point in the history

  2. Add new error code to decodeSyncSimple as well.

    @klauspost
    klauspost committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    62e6bdf View commit details
    Browse the repository at this point in the history