Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s2: Fix final emit oob read crash on amd64 #601

Merged
merged 1 commit into from
May 25, 2022
Merged

Conversation

klauspost
Copy link
Owner

When emitting the final literals we may not have enough input to safely read all without over-reading.

Set output margin to 0 for exact copies in this case.

Fixes #600

When emitting the final literals we may not have enough input to safely read all without over-reading.

Set output margin to 0 for exact copies in this case.

Fixes #600
@klauspost klauspost changed the title s2: Fix final emit oob reads s2: amd64 - Fix final emit oob read crash May 25, 2022
@klauspost klauspost merged commit ab138a9 into master May 25, 2022
@klauspost klauspost deleted the s2-fix-final-emit branch May 25, 2022 09:59
@klauspost klauspost changed the title s2: amd64 - Fix final emit oob read crash s2: Fix final emit oob read crash on amd64 May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

s2: Investigate crash
1 participant