Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zstd: Allow to ignore checksum checking #572

Merged
merged 1 commit into from
Apr 28, 2022
Merged

zstd: Allow to ignore checksum checking #572

merged 1 commit into from
Apr 28, 2022

Conversation

WojciechMula
Copy link
Contributor

Closes #571

There might be scenarios for which checksum validation is not necessary.

klauspost
klauspost requested changes Apr 28, 2022
View reviewed changes
Copy link
Owner

@klauspost klauspost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we actually skipping calculating the crc anywhere?

You would have to skip crc.Write(...) calls, otherwise you are still calculating crc, just not comparing it at the end.

@WojciechMula
zstd: Allow to ignore checksum checking
8098bd8 
There might be scenarios for which checksum validation is not necessary.
klauspost
klauspost approved these changes Apr 28, 2022
View reviewed changes
Copy link
Owner

@klauspost klauspost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@klauspost klauspost merged commit 75b1f22 into klauspost:master Apr 28, 2022
@WojciechMula WojciechMula deleted the zstd-ignore-checksum branch April 28, 2022 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klauspost klauspost klauspost approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

zstd: explicitly disable checksum checking
2 participants
@WojciechMula @klauspost