zstd: Forward read errors #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forward all read errors. Fixes #372
twmb
reviewed
May 25, 2021
| return io.ErrUnexpectedEOF | ||
| tmp, err := br.readSmall(3) | ||
| if err != nil { | ||
| println("Reading block header:", err) |
There was a problem hiding this comment.
Are these printlns meant to be gated with debug?
There was a problem hiding this comment.
Ah thank you very much! I didn't see that this was an override of the Go builtin, but seeing two arguments should've been the hint.
mostynb
added a commit
to mostynb/zstdpool-syncpool
that referenced
this pull request
May 30, 2021
This includes the following zstd improvement since v1.12.2: * Forward read errors klauspost/compress#373
mostynb
added a commit
to mostynb/go-grpc-compression
that referenced
this pull request
May 30, 2021
This includes the following zstd improvement since v1.12.2: * zstd: Forward read errors (#373) klauspost/compress#373
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward all read errors.
Fixes #372