zstd: Add helpers to compress/decompress zstd inside zip files #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds ZipCompressor and ZipDecompressor as well as method constants.
mostynb
added a commit
to mostynb/zstdpool-syncpool
that referenced
this pull request
Apr 28, 2021
This includes the following zstd improvement since v1.12.1: * Add helpers to compress/decompress zstd inside zip files klauspost/compress#363 * Improve best compression klauspost/compress#360 * Improve better compression klauspost/compress#364 * Improve compression with dictionaries too klauspost/compress#365
mostynb
added a commit
to mostynb/go-grpc-compression
that referenced
this pull request
Apr 28, 2021
This includes the following zstd improvement since v1.12.1: * Add helpers to compress/decompress zstd inside zip files klauspost/compress#363 * Improve best compression klauspost/compress#360 * Improve better compression klauspost/compress#364 * Improve compression with dictionaries too klauspost/compress#365
|
@klauspost Therefore these two constants can be merged into one: // ZipMethodWinZip is the method for Zstandard compressed data inside Zip files for WinZip.
// See https://www.winzip.com/win/en/comp_info.html
const ZipMethodWinZip = 93
// ZipMethodPKWare is the method number used by PKWARE to indicate Zstandard compression.
// See https://pkware.cachefly.net/webdocs/APPNOTE/APPNOTE-6.3.7.TXT
const ZipMethodPKWare = 20https://pkware.cachefly.net/webdocs/APPNOTE/APPNOTE-6.3.9.TXT |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ZipCompressor and ZipDecompressor as well as method constants.
Winzip confirmed... PKWARE, no idea... download form doesn't work.
7zip detects it, but cannot decompress.