Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new wait alias for await logger #73

Merged
merged 1 commit into from
Jan 24, 2019
Merged

Added new wait alias for await logger #73

merged 1 commit into from
Jan 24, 2019

Conversation

klaudiosinani
Copy link
Owner

@klaudiosinani klaudiosinani commented Jan 24, 2019

Description

Due to the fact that await is a reserved keyword used exclusively under the scope of async functions, a new wait type logger is introduced by this PR, which will act as an alias/alternative. The main purpose for this addition is for the API to be in sync with the best possible practices design-wise and to prevent any possible inconveniences, (not actual parsing or runtime errors), resulting from the usage a function named await, such as code linting errors, confusion during debugging or auditing etc.

// example.js
const {await} = require('signale');

await('Executing calculation...');
// Possible linting error: 'Can not use keyword await outside an async function'

The existing await logger will not be removed from the API for backwards compatibility reasons, but its usage will be discouraged and wait will be counter-proposed on the API docs.

@klaudiosinani klaudiosinani added the enhancement New feature or request label Jan 24, 2019
@klaudiosinani klaudiosinani merged commit da9a41c into master Jan 24, 2019
@klaudiosinani klaudiosinani deleted the wait branch January 24, 2019 21:18
akadop added a commit to akadop/signale that referenced this pull request Jan 29, 2019
Added new `wait` alias for `await` logger (klaudiosinani#73)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant