feat(): type definition for signale #25

rjoydip-zz · 2018-05-27T16:53:39Z

Type definition for Signal.

jannislehmann · 2018-06-02T12:55:46Z

+1
Hopefully this gets merged as I could use the typings currently.

jordrake · 2018-06-02T14:44:30Z

index.d.ts

+export interface Stream { }
+export interface Config { displayScope?: Boolean; displayBadge?: Boolean; displayDate?: Boolean; displayFilename?: Boolean; displayLabel?: Boolean; displayTimestamp?: Boolean; underlineLabel?: Boolean; underlineMessage?: Boolean; underlinePrefix?: Boolean; underlineSuffix?: Boolean; uppercaseLabel?: Boolean; }
+export interface Options { times?: Times; types: Types; stream?: Stream; scope?: String; }
+export interface CompleteArrgumentType { prefix?: String; message: String; suffix?: String; }


You have misspelt argument. Unless you're a pirate ☠️

@jordrake Can you tell me which one I misspelled? 😕

CompleteArrgumentType

@Cludch and @jordrake Thanks for pointing me. Now, this is fixed.

…sue-20

resir014 · 2018-06-10T06:54:35Z

Hey @rjoydip @klauscfhq,

As mentioned on #39, I accidentally started work on my own version of the type declarations without checking here if someone had done it first. It's currently awaiting PR on DefinitelyTyped, but I can port them over here and I'd be glad to contribute to this PR if needed. :)

Thanks!

rjoydip-zz · 2018-06-10T08:33:01Z

@resir014 Your type declarations is far better than my one. So if you give me the permission then I will take your code in here. Once it merged then anybody can extend. Otherwise, I will close this and you can make new PR.

resir014 · 2018-06-10T08:40:08Z

@rjoydip Sure, no problem :) And feel free to add your name + github to the header as well.

rjoydip-zz · 2018-06-10T13:17:31Z

@resir014 Thank you so much.

…to ts-definition

rjoydip-zz · 2018-06-10T14:47:57Z

Awesome.

resir014 · 2018-06-10T16:25:02Z

@rjoydip Alright, that's all that I could review for today, I need to go to bed.

I'll have another look tomorrow, but IMO this should be good to merge for now.

rjoydip-zz · 2018-06-10T16:32:27Z

Yes. @resir014 Thanks once again. It couldn't be good without your help.

rjoydip-zz · 2018-06-10T16:48:04Z

As described in issue #42. When i was checking signale.success(Symbol('test').toString()); I am getting this error error TS2349: Cannot invoke an expression whose type lacks a call signature. Type 'SymbolConstructor' has no compatible call signatures.

have to check this one

resir014 · 2018-06-11T01:28:59Z

@rjoydip Alright. If you want me to, you can also give me push access to your fork and I can work on it as well. :)

rjoydip-zz · 2018-06-11T03:25:45Z

@resir014 Please check it I gave you the access.

We no longer need them as we already base everything off of tsconfig

resir014 · 2018-06-11T04:55:53Z

Thanks @rjoydip!

I'm going to make a few changes:

I've renamed the tests folder to the types folder, and moved the signale.d.ts file in there.
This means we can include the .d.ts file inside the types folder and not worry about the compiler errors on the Map interface.
Attempted to fix the commonjs default export issue

Not sure if this ordering is necessary, but let's use it anyway.

rjoydip-zz · 2018-06-11T05:43:45Z

No problem. Change it

resir014 · 2018-06-11T05:46:45Z

It's done. :)

…

On Mon, 11 Jun 2018, 12:43 Joydip Roy, ***@***.***> wrote: No problem. Change it — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#25 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFZsha5OjDET77iS5wOAD3LXVCP-nL-5ks5t7gOUgaJpZM4UPWTH> .

itsMapleLeaf · 2018-06-11T07:27:38Z

types/signale.d.ts

+};
+
+export = signale;
+export as namespace signale;


The export as namespace declaration is used with modules that export some sort of global variable. See here and here. Since Signale appears to be a CommonJS-only module and doesn't export a global, this line can probably be removed.

Fixed. 👌

resir014 · 2018-06-11T18:49:33Z

@klauscfhq this should be ready to review 👌

Eke · 2018-06-20T07:53:05Z

Hello, any updates on this? I would love to have this in my project.

resir014 · 2018-06-21T01:03:30Z

@Eke Hi, I'm still pushing for this to be merged as well. I've updated the typings with the missing config objects from version 1.2.0 and now this should be ready for @klauscfhq to review and merge.

klaudiosinani

Thank you all a lot for taking the time to contribute and work on this one!

rjoydip and others added 8 commits May 27, 2018 14:21

feat(): support printf-like formatting

5731fa2

fix(test): removed one code comment

e244713

fix(klaudiosinani#24): Print stringified and colorized objects

50755f5

feat(): type defination added and WIP

5aeff69

Merge branch 'master' into issue-20

d384e37

Merge branch 'master' into issue-20

4bee762

modify defination file

02c3e62

unknown reason

c0bd969

jordrake reviewed Jun 2, 2018

View reviewed changes

rjoydip and others added 4 commits June 2, 2018 20:49

removed types

a282dc0

fix: misspelling

0f07c36

added config method

90ed398

Merge branch 'master' into issue-20

bb02846

klaudiosinani added the enhancement New feature or request label Jun 6, 2018

rjoydip added 5 commits June 9, 2018 12:09

refactor: requested changes done but except message destructuring

9e1cac7

Merge branch 'issue-20' of https://github.com/rjoydip/signale into is…

cdbf135

…sue-20

Merge branch 'master' into ts-definition

b6e11dd

Merge branch 'master' into ts-definition

61228b7

Merge branch 'master' into issue-20

5b6b670

klaudiosinani mentioned this pull request Jun 9, 2018

Typescript types #39

Closed

klaudiosinani self-requested a review June 9, 2018 15:51

Merge branch 'master' into ts-definition

d1f4fd4

rjoydip added 3 commits June 10, 2018 19:22

remodified ts defination

dbb1992

xo ignore test folder

ff59a0d

Merge branch 'ts-definition' of https://github.com/rjoydip/signale in…

5e5c5ea

…to ts-definition

rjoydip added 2 commits June 10, 2018 20:36

chnaged tsconfig lib es5 -> es6

9dedb5d

conflict resolve

26b8e52

resir014 added 2 commits June 11, 2018 11:08

rename test to types, move signale.d.ts inside types folder

5a4dd0c

remove Map and Set polyfills

54c1eb7

We no longer need them as we already base everything off of tsconfig

resir014 added 5 commits June 11, 2018 11:56

fix commonJS default export issue

05c95bc

fixed header comment, reodered commonjs exports

c3d4c00

Not sure if this ordering is necessary, but let's use it anyway.

whitespace

9831e70

fixed gitignore

8566787

updated files on tsconfig.json

5a9793c

itsMapleLeaf reviewed Jun 11, 2018

View reviewed changes

remove export as namespace declaration since no globals is exported

f86a7f3

resir014 added 2 commits June 21, 2018 07:59

Merge remote-tracking branch 'upstream/master' into ts-definition

986ef59

Added missing options from 1.2.0

24b8aaa

klaudiosinani requested review from klaudiosinani and removed request for klaudiosinani March 15, 2019 20:04

klaudiosinani approved these changes Mar 15, 2019

View reviewed changes

klaudiosinani merged commit de6bb2e into klaudiosinani:master Mar 15, 2019

rjoydip-zz deleted the ts-definition branch March 16, 2019 08:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(): type definition for signale #25

feat(): type definition for signale #25

rjoydip-zz commented May 27, 2018 •

edited

Loading

jannislehmann commented Jun 2, 2018

jordrake Jun 2, 2018

rjoydip-zz Jun 2, 2018 •

edited

Loading

jannislehmann Jun 2, 2018

rjoydip-zz Jun 2, 2018 •

edited

Loading

resir014 commented Jun 10, 2018

rjoydip-zz commented Jun 10, 2018

resir014 commented Jun 10, 2018

rjoydip-zz commented Jun 10, 2018

rjoydip-zz commented Jun 10, 2018

resir014 commented Jun 10, 2018

rjoydip-zz commented Jun 10, 2018

rjoydip-zz commented Jun 10, 2018 •

edited

Loading

resir014 commented Jun 11, 2018

rjoydip-zz commented Jun 11, 2018

resir014 commented Jun 11, 2018

rjoydip-zz commented Jun 11, 2018

resir014 commented Jun 11, 2018 via email

itsMapleLeaf Jun 11, 2018

resir014 Jun 11, 2018

resir014 commented Jun 11, 2018

Eke commented Jun 20, 2018

resir014 commented Jun 21, 2018

klaudiosinani left a comment

feat(): type definition for signale #25

feat(): type definition for signale #25

Conversation

rjoydip-zz commented May 27, 2018 • edited Loading

jannislehmann commented Jun 2, 2018

jordrake Jun 2, 2018

Choose a reason for hiding this comment

rjoydip-zz Jun 2, 2018 • edited Loading

Choose a reason for hiding this comment

jannislehmann Jun 2, 2018

Choose a reason for hiding this comment

rjoydip-zz Jun 2, 2018 • edited Loading

Choose a reason for hiding this comment

resir014 commented Jun 10, 2018

rjoydip-zz commented Jun 10, 2018

resir014 commented Jun 10, 2018

rjoydip-zz commented Jun 10, 2018

rjoydip-zz commented Jun 10, 2018

resir014 commented Jun 10, 2018

rjoydip-zz commented Jun 10, 2018

rjoydip-zz commented Jun 10, 2018 • edited Loading

resir014 commented Jun 11, 2018

rjoydip-zz commented Jun 11, 2018

resir014 commented Jun 11, 2018

rjoydip-zz commented Jun 11, 2018

resir014 commented Jun 11, 2018 via email

itsMapleLeaf Jun 11, 2018

Choose a reason for hiding this comment

resir014 Jun 11, 2018

Choose a reason for hiding this comment

resir014 commented Jun 11, 2018

Eke commented Jun 20, 2018

resir014 commented Jun 21, 2018

klaudiosinani left a comment

Choose a reason for hiding this comment

rjoydip-zz commented May 27, 2018 •

edited

Loading

rjoydip-zz Jun 2, 2018 •

edited

Loading

rjoydip-zz Jun 2, 2018 •

edited

Loading

rjoydip-zz commented Jun 10, 2018 •

edited

Loading