Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cross-env support #85

Merged
merged 3 commits into from
Sep 24, 2019
Merged

Add cross-env support #85

merged 3 commits into from
Sep 24, 2019

Conversation

BhaveshSGupta
Copy link
Contributor

To make build possible even on windows.

@jaller94
Copy link
Contributor

This works for you?
I thought lines with multiple variables and commands need one cross-env-shell at the start of the line instead of multiple cross-env.
https://www.npmjs.com/package/cross-env#cross-env-vs-cross-env-shell

Don't have a Windows to test this though. If you say this works, it can get merged.

@BhaveshSGupta
Copy link
Contributor Author

BhaveshSGupta commented Aug 13, 2019

cross-env works fine,
Although I had checked only make-dev and make-watch. But I found make is giving error at APP_VERSION=git tag --points-at HEAD saying tag is not defined.

kentcdodds/cross-env#206

@jaller94
Copy link
Contributor

Without a tag on the currently checked out HEAD, the command should not output a string.

@jaller94 jaller94 added the help wanted Extra attention is needed label Aug 30, 2019
@jaller94
Copy link
Contributor

I don't see a way to edit your branch so I "forked" your PR to #89.

@BhaveshSGupta
Copy link
Contributor Author

@jaller94 This issue is now fixed as per my new commits, can you review them.

@jaller94
Copy link
Contributor

Fixes #95.

@jaller94 jaller94 removed the help wanted Extra attention is needed label Sep 23, 2019
@jaller94 jaller94 merged commit d64bef9 into klaro-org:master Sep 24, 2019
@jaller94
Copy link
Contributor

jaller94 commented Dec 3, 2019

For every release after v0.2.11 Windows users will have to set their NPM shell to power-shell.
We start using string substitution to fix issue #131.

Further information:
https://www.npmjs.com/package/cross-env#windows-issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants