mutable Helper in functions

[zao111222333]

See gwenn#4
And I add a new example/bracket_parser.rs to demo Parser trait.

btw, rightnow I have no idea how to represent change: InputEdit.

[gwenn]

Thank you for all your proposals.
But please only one feature at a time: either mut Helper or Parser but not both in the same PR.

[gwenn]

not sure why you need the mut validator

[zao111222333]

The match block requires the input validator is mutable. And when we call it, use readline_direct(io::stdin().lock(), io::stderr(), self.helper.as_mut()), it is almost same as before

rustyline/src/lib.rs

Lines 519 to 523 in 77e7d3d

	match validator {
	None => return Ok(input),
	Some(ref mut v) => {
	let mut ctx = input.as_str();
	let mut ctx = validate::ValidationContext::new(&mut ctx);

[gwenn]

Ok

[gwenn]

See

rustyline/src/validate.rs

Lines 44 to 47 in ceafb7f

	// TODO
	//fn invoke(&mut self, cmd: Cmd) -> Result<?> {
	// self.i.invoke(cmd)
	//}

[gwenn]

No split-highlight in this PR please

[zao111222333]

I am sorry for that, I directly copy rustyline-derive/src/lib.rs for the old version. I only copy this single file and I will remove those :)

[gwenn]

No worry !

[gwenn]

Remove all Parser / split-highlight related code

[gwenn]

See

rustyline/src/undo.rs

Line 9 in ceafb7f

enum Change {

for a possible InputEdit impl (except for Begin / End)

[zao111222333]

But please only one feature at a time: either mut Helper or Parser but not both in the same PR.

Understand, and since the Parser::parse requires &mut self, I think I can firstly fix all issue (like create ValidationContext from State) for mut Helper. Merge it firstly.
And then create another PR for Parser (as well as InputEdit)

[zao111222333]

Here is the update under your suggestions.
I think the Invoke should impl for LineBuffer and String, rather than State and &str.
The &str could be replaced to String since itself will be changed in invoke.
And State could be replaced to LineBuffer since Invoke seems only require LineBuffer.
How do you think that?

I haven't fixed fn invoke(&mut self, cmd: Cmd) in this commit, I will try to implement this feature in future.

[gwenn]

You need the State to invoke a Cmd on a LineBuffer for Undo / Kill ring.
Like Changeset here:

rustyline/src/completion.rs

Lines 102 to 105 in ceafb7f

	fn update(&self, line: &mut LineBuffer, start: usize, elected: &str, cl: &mut Changeset) {
	let end = line.pos();
	line.replace(start..end, elected, cl);
	}

[zao111222333]

Or at least use a part of State to create a ValidationContext? Since here we already make a mutable reference from State.helper, then it's difficult to have another mutable refence from entire State (will be ValidationContext::new(self) in code).

rustyline/src/edit.rs

Lines 250 to 253 in 8fc0037

	if let Some(ref mut validator) = self.helper {
	self.changes.begin();
	let result =
	(*validator).validate(&mut ValidationContext::new(&mut self.line))?;

Now I am not sure which State attributs are needed for fn invoke.