Detach hint title from completion text#414
Merged
gwenn merged 1 commit intokkawakam:masterfrom Aug 23, 2020
Merged
Conversation
Fixes kkawakam#397, and perhaps kkawakam#413
gwenn
reviewed
Jul 14, 2020
Comment on lines
+54
to
+58
| fn hint(&self, _line: &str, _pos: usize, _ctx: &rustyline::Context<'_>) | ||
| -> Option<Self::Hint> | ||
| { | ||
| None | ||
| } |
gwenn
reviewed
Jul 14, 2020
| let (impl_generics, ty_generics, where_clause) = generics.split_for_impl(); | ||
| let expanded = quote! { | ||
| impl #impl_generics rustyline::hint::Hinter for #name #ty_generics #where_clause { | ||
| type Hint = String; |
Merged
Contributor
Author
|
Thank you. Sorry that I didn't find time to finish this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This solution came up in disussion of #397
Fixes #397, and perhaps #413