Updated history to escape history entries differently#411
Closed
fdncred wants to merge 4 commits intokkawakam:masterfrom
fdncred:master
Closed
Updated history to escape history entries differently#411fdncred wants to merge 4 commits intokkawakam:masterfrom fdncred:master
fdncred wants to merge 4 commits intokkawakam:masterfrom
fdncred:master
Conversation
Author
|
There is an |
Collaborator
|
Thanks for your PR but:
See #412. |
Author
|
@gwenn Ok. Looks good to me. Thanks for putting my test in there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@gwenn How's this for a fix for #409?
I used the
snailquoteescaping/unescaping crate found hereI tested it with nushell and it seemed to work, once I straightened out my history.txt file