Add google storage support for remote uploads #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I’m quite busy at the moment but will review in the next couple weeks. |
|
@kjvarga do you have any ETA about such PR? We would like to use such feature. |
|
Thanks for the pull request. I've gotten around this this in my Christmas break :) I've made some changes but your configuration should still work. Could you test it out and make sure it's working for you? https://rubygems.org/gems/sitemap_generator/versions/6.1.0 |
|
Merged in #340 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @kjvarga,
I have added
GoogleStorageAdapterto support remote uploads Google Cloud Storage. Pease review the PR. I am already using this in one of my application, so I know that this works. I saw an issue for Google Storage so I thought I'd help out.Let me know if there's an issue.