Feature coauthor support #102
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kixlab ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jhw123
requested changes
Feb 20, 2025
| ) | ||
| )} | ||
| </AuthorList> | ||
| const printAuthor = (author: Member | string, asterisks: string) => { |
There was a problem hiding this comment.
Since this returns a component, the name should be PrintAuthor. I would change the name to Name
| @@ -164,6 +164,7 @@ export const MEMBERS: Record<string, Member> = { | |||
| email: '[email protected]', | |||
| kixlabPosition: 'Postdoc Researcher', | |||
| img: 'daehyun.jpg', | |||
| isAlumni: true, | |||
There was a problem hiding this comment.
why can't we use endDate to indicate if the person is an alumnus? I would change endYear to endDate
| startSeason: 'Summer', | ||
| }, | ||
| // How should we handle Sung-Chul's entry? | ||
| // sungchullee: { |
|
this branch is checked out from the other branch. If you are merging a branch into main, the branch should be from main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #62