If PDF viewer is not enabled PDFs are downloaded instead #1177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1177 +/- ##
=======================================
Coverage 41.47% 41.47%
=======================================
Files 59 59
Lines 4272 4272
Branches 2336 2336
=======================================
Hits 1772 1772
Misses 1002 1002
Partials 1498 1498 ☔ View full report in Codecov by Sentry. |
Chrome on Android doesn't support displaying PDF documents inline so an attempt to load a PDF into the Kiwix viewer iframe fails in a way that may be confusing to the users. In such situations it is better to offer to the users to download the PDF file so that they can view it with a dedicated application. Making the clicked PDF link to open in a new tab/window achieves exactly that effect.
veloman-yunkan
force-pushed
the
handling_of_pdf_links_under_chrome_on_android
branch
from
b90752a to
b6ce647
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chrome on Android doesn't support displaying PDF documents inline so an attempt to load a PDF into the Kiwix viewer iframe fails in a way that may be confusing to the users. In such situations it is better to offer to the users to download the PDF file so that they can view it with a dedicated application. Making the link to open in a new tab/window achieves exactly that effect.
Fixes kiwix/kiwix-tools#670