Cleanup of error response generation #1030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1030 +/- ##
==========================================
+ Coverage 38.88% 38.95% +0.07%
==========================================
Files 58 58
Lines 3991 3958 -33
Branches 2204 2181 -23
==========================================
- Hits 1552 1542 -10
+ Misses 1090 1086 -4
+ Partials 1349 1330 -19 ☔ View full report in Codecov by Sentry. |
mgautierfr
requested changes
Nov 29, 2023
veloman-yunkan
force-pushed
the
cleanup_of_error_response_generation
branch
from
b4fa17d to
9c174e4
Compare
It makes little sense to pass the verbosity control to the `Response` constructor if it is used only in `Response::send()`.
It turned out that ContentResponse::m_root is no longer used. At this point, the root parameter is dropped only from the 3-ary variant of ContentResponse::build(), so that its all call sites are automatically discovered by the compiler (and updated manually). Including the other (4-ary) variant of ContentResponse::build() in this change might result in the semantic change of expressions like `ContentResponse::build(x, y, z)` and failure to update them.
veloman-yunkan
force-pushed
the
cleanup_of_error_response_generation
branch
from
9c174e4 to
5f27b4b
Compare
|
@mgautierfr Good to merge? |
mgautierfr
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains preparatory cleanup work before implementing translation of error pages (#1019).