Try yet another obscure approach, sigh

kiwix · Aug 19, 2024 · 9d10565 · 9d10565
1 parent 798c147
commit 9d10565
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/.github/workflows/build-electron.yml b/.github/workflows/build-electron.yml
@@ -263,7 +263,9 @@ jobs:
         if ($INPUT_SIGN) {
           npm run dist-win-nsis
         } else {
-          npm run dist-win-nsis-skipsigning
+          $Env:CSC_IDENTITY_AUTO_DISCOVERY = "false"
+          npm run dist-win-nsis
+          $Env:CSC_IDENTITY_AUTO_DISCOVERY = $null
         }
         echo "Renaming Windows 7+ executable"
         $files = @("Kiwix JS Electron", "WikiMed by Kiwix", "Wikivoyage by Kiwix")
@@ -303,7 +305,9 @@ jobs:
         if ($INPUT_SIGN) {
           npm run publish
         } else {
-          npm run build-skipsigning
+          $Env:CSC_IDENTITY_AUTO_DISCOVERY = "false"
+          npm run build
+          $Env:CSC_IDENTITY_AUTO_DISCOVERY = $null
         }
         ./scripts/Rewrite-DraftReleaseTag.ps1
     - name: Build portable Electron app

diff --git a/package.json b/package.json
@@ -130,12 +130,10 @@
     "dist-win": "electron-builder build --win --projectDir dist",
     "dist-win-arm64": "electron-builder build --win NSIS:arm64 --projectDir dist",
     "dist-win-nsis": "electron-builder build --win NSIS:ia32 --publish never --projectDir dist",
-    "dist-win-nsis-skipsigning": "CSC_IDENTITY_AUTO_DISCOVERY=false electron-builder build --win NSIS:ia32 --win.sign=false --publish never --projectDir dist",
     "dist-win-nisis-x64": "electron-builder build --win NSIS:x64 --publish never --projectDir dist",
     "dist-linux": "electron-builder build --linux --projectDir dist",
     "dist-linux-appimage": "electron-builder build --linux AppImage:x64 --projectDir dist",
     "publish": "electron-builder build --projectDir dist",
-    "build-skipsigning": "CSC_IDENTITY_AUTO_DISCOVERY=false electron-builder build --projectDir dist --publish never",
     "postpackage-win": "(robocopy archives bld\\Electron\\kiwix-js-pwa-win32-ia32\\resources\\app\\archives\\ > null) ^& IF %ERRORLEVEL% LSS 8 SET ERRORLEVEL = 0",
     "postpackage-linux": "(robocopy archives bld\\Electron\\kiwix-js-pwa-linux-x64\\archives\\ > null) ^& IF %ERRORLEVEL% LSS 8 SET ERRORLEVEL = 0"
   },