fix Epub empty array with getChapters func #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #91 +/- ##
============================================
- Coverage 90.55% 90.54% -0.01%
Complexity 826 826
============================================
Files 32 32
Lines 2540 2539 -1
============================================
- Hits 2300 2299 -1
Misses 240 240 ☔ View full report in Codecov by Sentry. |
|
Okay, no problem! I merge this one! |
ewilan-riviere
added a commit
that referenced
this pull request
Jul 16, 2024
Hotfix PR #91 for issue #71 by @basitcodeenv, thanks!
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I upgrade php-ebook package to latest version and It still was not working because I forgot to remove one line in my Previous PR which I have done in this PR.