Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#29 Call to a member function format() on false in AudioCore.php:543 #30

Merged
merged 1 commit into from
Jun 4, 2024
Merged

#29 Call to a member function format() on false in AudioCore.php:543 #30

merged 1 commit into from
Jun 4, 2024

Conversation

panVag
Copy link
Contributor

@panVag panVag commented Jun 3, 2024

Fixes #29 by:

  • use DateTimeImmutable super powers to parse date and datetime strings
  • catch and ignore exception when instantiating the aforementioned object so the whole script won't fail
  • remove the null safe operators when it's not needed

@ewilan-riviere ewilan-riviere self-assigned this Jun 4, 2024
@ewilan-riviere ewilan-riviere merged commit 04469ec into kiwilan:main Jun 4, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Call to a member function format() on false in AudioCore.php:543
2 participants