Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Graphite]: fix #443 #444

Closed
wants to merge 0 commits into from
Closed

Conversation

dabo-devconsole
Copy link

@dabo-devconsole dabo-devconsole commented Feb 1, 2022

What this PR does / why we need it:

  • template ingress in all api versions and add ingress class

Which issue this PR fixes

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped (if the pr is an update to an existing chart)
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [fluentd-elasticsearch])

@dabo-ZON
Copy link

dabo-ZON commented Feb 4, 2022

Hi @monotek,

can you please have a look at this PR? It should fix the ingress api deprecation in K8s >= 1.22 and is also compatible with older versions. Is there something I missed, that I can contribute to. Thank you.

Best regards,
dabo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

graphite - deprecated API ingress resource
2 participants