Skip to content

Commit

Permalink
Removed empty line after imagePullSecrets if it is set.
Browse files Browse the repository at this point in the history
`toYaml` currently and unintentionally creates a new line at the end of its output. This is going to be fixed in Helm 3 but not in Helm 2 since it would break existing charts (see helm/helm#3470).

Signed-off-by: Brandon Schmitt <[email protected]>
  • Loading branch information
BrandonSchmitt committed Jul 8, 2019
1 parent b84ed61 commit 374ca1a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion charts/hawkbit-update-server/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ spec:
spec:
{{- with .Values.image.pullSecrets }}
imagePullSecrets:
{{- toYaml . | nindent 8 }}
{{- toYaml . | trimSuffix "\n" | nindent 8 }}
{{- end }}
containers:
- name: {{ .Chart.Name }}
Expand Down

0 comments on commit 374ca1a

Please sign in to comment.