Use shutil.which instead of sh.which
#2637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreMiras
approved these changes
Jul 19, 2022
manuq
added a commit
to endlessm/python-for-android
that referenced
this pull request
Aug 1, 2022
Handcrafted version of this patch upstream: kivy#2637 https://phabricator.endlessm.com/T33736
SomberNight
pushed a commit
to SomberNight/python-for-android
that referenced
this pull request
Oct 10, 2022
SomberNight
pushed a commit
to SomberNight/python-for-android
that referenced
this pull request
Oct 14, 2022
accumulator
pushed a commit
to accumulator/python-for-android
that referenced
this pull request
Oct 18, 2022
accumulator
pushed a commit
to accumulator/python-for-android
that referenced
this pull request
Jan 5, 2023
accumulator
pushed a commit
to accumulator/python-for-android
that referenced
this pull request
Jan 5, 2023
accumulator
pushed a commit
to accumulator/python-for-android
that referenced
this pull request
Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently our CI started to fail when checking the availability of certain tools (E.g.
lld,ccache...)See: https://github.com/kivy/python-for-android/runs/7394641730
shreleased a new version (1.14.3, 12 hours ago) with a breaking change on our side.This is due to Make sh.which() an internal function amoffat/sh#584
They are right, and in order to achieve what we expect
shutil.which("name")should be used instead, as returnsNonewhen a cmd is not found.From Python docs: