feat(android-filechooser): Implement save file method #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @leestarb ! Our style checks are failing on your PR, can you take care of it? |
Ok! This is just style issues |
|
I"m sorry for being so late, but I did it. Now please approve the workflows, @misl6 🫠 |
|
Hello @misl6 . Finally it is OK with the style of code! |
misl6
approved these changes
Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works like a charm!
Tested on: python 3.8.15; kivy 2.1.0; plyer 2.1.0; Android 13 on pure AOSP
Pros:
This doesn't need any permissions. Neither any manifest nor config changes (Absolutely no any).
Always uses the default file explorer in the system.
Purely native code approved by the Google's android guide.
The same code (but in Kotlin) tested with my production app on 5, 7, 9, 10, 12, 13 versions of Android.
This supports the default file name value as
titleargument.Comfortable handling of the file output stream with the callback argument. Not so good due to the lack of type hints but there always are the java docs!
Cons:
Still uses deprecated onActivityResult (same as
open_filedoes. I think this is not so bad (This also used on the Google's guide).Improvements and tests are appreciated!
Closes #661 ;)