Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing import #563

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

missing import #563

wants to merge 1 commit into from

Conversation

mflaxman
Copy link

@mflaxman mflaxman commented Nov 3, 2020

$ python3 toolchain.py build zbarlight
...
Traceback (most recent call last):
  File "toolchain.py", line 3, in <module>
    main()
  File "/Users/mflaxman/workspace/kivy-ios/kivy_ios/toolchain.py", line 1519, in main
    ToolchainCL()
  File "/Users/mflaxman/workspace/kivy-ios/kivy_ios/toolchain.py", line 1276, in __init__
    getattr(self, args.command)()
  File "/Users/mflaxman/workspace/kivy-ios/kivy_ios/toolchain.py", line 1337, in build
    build_recipes(args.recipe, ctx)
  File "/Users/mflaxman/workspace/kivy-ios/kivy_ios/toolchain.py", line 1127, in build_recipes
    recipe.execute()
  File "/Users/mflaxman/workspace/kivy-ios/kivy_ios/toolchain.py", line 699, in execute
    self.build_all()
  File "/Users/mflaxman/workspace/kivy-ios/kivy_ios/toolchain.py", line 73, in _cache_execution
    f(self, *args, **kwargs)
  File "/Users/mflaxman/workspace/kivy-ios/kivy_ios/toolchain.py", line 793, in build_all
    self.build(arch)
  File "/Users/mflaxman/workspace/kivy-ios/kivy_ios/toolchain.py", line 73, in _cache_execution
    f(self, *args, **kwargs)
  File "/Users/mflaxman/workspace/kivy-ios/kivy_ios/toolchain.py", line 780, in build
    self.build_arch(arch)
  File "/Users/mflaxman/workspace/kivy-ios/kivy_ios/recipes/zbarlight/__init__.py", line 38, in build_arch
    shprint(hostpython, "setup.py", "build",   # noqa: F821
NameError: name 'shprint' is not defined

Even with this bugfix I'm still getting an error, but it could be specific to my environment.

```
$ python3 toolchain.py build zbarlight
...
Traceback (most recent call last):
  File "toolchain.py", line 3, in <module>
    main()
  File "/Users/mflaxman/workspace/kivy-ios/kivy_ios/toolchain.py", line 1519, in main
    ToolchainCL()
  File "/Users/mflaxman/workspace/kivy-ios/kivy_ios/toolchain.py", line 1276, in __init__
    getattr(self, args.command)()
  File "/Users/mflaxman/workspace/kivy-ios/kivy_ios/toolchain.py", line 1337, in build
    build_recipes(args.recipe, ctx)
  File "/Users/mflaxman/workspace/kivy-ios/kivy_ios/toolchain.py", line 1127, in build_recipes
    recipe.execute()
  File "/Users/mflaxman/workspace/kivy-ios/kivy_ios/toolchain.py", line 699, in execute
    self.build_all()
  File "/Users/mflaxman/workspace/kivy-ios/kivy_ios/toolchain.py", line 73, in _cache_execution
    f(self, *args, **kwargs)
  File "/Users/mflaxman/workspace/kivy-ios/kivy_ios/toolchain.py", line 793, in build_all
    self.build(arch)
  File "/Users/mflaxman/workspace/kivy-ios/kivy_ios/toolchain.py", line 73, in _cache_execution
    f(self, *args, **kwargs)
  File "/Users/mflaxman/workspace/kivy-ios/kivy_ios/toolchain.py", line 780, in build
    self.build_arch(arch)
  File "/Users/mflaxman/workspace/kivy-ios/kivy_ios/recipes/zbarlight/__init__.py", line 38, in build_arch
    shprint(hostpython, "setup.py", "build",   # noqa: F821
NameError: name 'shprint' is not defined
```

Even with this bugfix I'm still getting an error, but it could be specific to my environment.
@misl6 misl6 added this to the 1.2.1 milestone Dec 26, 2020
@misl6
Copy link
Member

misl6 commented Dec 26, 2020

@mflaxman sorry for the delay.

As you said, I see from the CI that the recipe it's still failing to build:

2020-11-03T20:05:55.3280170Z [DEBUG   ] copying src/zbarlight/_zbarlight.c -> build/lib.macosx-10.15-x86_64-3.8/zbarlight
2020-11-03T20:05:55.3286460Z [DEBUG   ] running build_ext
2020-11-03T20:05:55.3301900Z [DEBUG   ] building 'zbarlight._zbarlight' extension
2020-11-03T20:05:55.3304030Z [DEBUG   ] creating build/temp.macosx-10.15-x86_64-3.8
2020-11-03T20:05:55.3305610Z [DEBUG   ] creating build/temp.macosx-10.15-x86_64-3.8/src
2020-11-03T20:05:55.3306760Z [DEBUG   ] creating build/temp.macosx-10.15-x86_64-3.8/src/zbarlight
2020-11-03T20:05:55.3310750Z [DEBUG   ] /var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/tmpcge10do2 -I/Users/runner/work/kivy-ios/kivy-ios/dist/include/x86_64/libzbar/zbar -arch x86_64 -I/Users/runner/work/kivy-ios/kivy-ios/dist/hostpython3/include/python3.8 -c src/zbarlight/_zbarlight.c -o build/temp.macosx-10.15-x86_64-3.8/src/zbarlight/_zbarlight.o -std=c99
2020-11-03T20:05:55.4326640Z [DEBUG   ] src/zbarlight/_zbarlight.c:3:10: fatal error: 'zbar.h' file not found
2020-11-03T20:05:55.4327180Z [DEBUG   ] #include <zbar.h>
2020-11-03T20:05:55.4327440Z [DEBUG   ]          ^~~~~~~~
2020-11-03T20:05:55.4368180Z [DEBUG   ] 1 error generated.
2020-11-03T20:05:55.4407230Z [DEBUG   ] error: command '/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/tmpcge10do2' failed with exit status 1

As far as I can see, the zbarlight and libzbar recipes are quite broken, and they need some love, so it's something unrelated to your environment.

Would you like to further investigate about it?

@misl6 misl6 removed this from the 1.2.1 milestone Jan 9, 2021
@Cheaterman
Copy link
Contributor

@mflaxman sorry for the delay.

As you said, I see from the CI that the recipe it's still failing to build:

2020-11-03T20:05:55.3280170Z [DEBUG   ] copying src/zbarlight/_zbarlight.c -> build/lib.macosx-10.15-x86_64-3.8/zbarlight
2020-11-03T20:05:55.3286460Z [DEBUG   ] running build_ext
2020-11-03T20:05:55.3301900Z [DEBUG   ] building 'zbarlight._zbarlight' extension
2020-11-03T20:05:55.3304030Z [DEBUG   ] creating build/temp.macosx-10.15-x86_64-3.8
2020-11-03T20:05:55.3305610Z [DEBUG   ] creating build/temp.macosx-10.15-x86_64-3.8/src
2020-11-03T20:05:55.3306760Z [DEBUG   ] creating build/temp.macosx-10.15-x86_64-3.8/src/zbarlight
2020-11-03T20:05:55.3310750Z [DEBUG   ] /var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/tmpcge10do2 -I/Users/runner/work/kivy-ios/kivy-ios/dist/include/x86_64/libzbar/zbar -arch x86_64 -I/Users/runner/work/kivy-ios/kivy-ios/dist/hostpython3/include/python3.8 -c src/zbarlight/_zbarlight.c -o build/temp.macosx-10.15-x86_64-3.8/src/zbarlight/_zbarlight.o -std=c99
2020-11-03T20:05:55.4326640Z [DEBUG   ] src/zbarlight/_zbarlight.c:3:10: fatal error: 'zbar.h' file not found
2020-11-03T20:05:55.4327180Z [DEBUG   ] #include <zbar.h>
2020-11-03T20:05:55.4327440Z [DEBUG   ]          ^~~~~~~~
2020-11-03T20:05:55.4368180Z [DEBUG   ] 1 error generated.
2020-11-03T20:05:55.4407230Z [DEBUG   ] error: command '/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/tmpcge10do2' failed with exit status 1

As far as I can see, the zbarlight and libzbar recipes are quite broken, and they need some love, so it's something unrelated to your environment.

Would you like to further investigate about it?

Just about to PR that :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants