use a source build of libpcre

[lun-4]

removes the need to link against system libpcre

exposed pcre-8.45 as zigpkg which was used for the zigmod version of this library: nektro/pcre-8.45#2 unknown if it'll be merged so libpcre.zig would depend on my fork of it

drawback is that macos won't compile with source build, it'll still use system libpcre by default such that nothing breaks fixed

(this update should be carried out to koino post-merge such that koino doesn't depend on my fork of libpcre.zig, so I didn't open a PR for that yet)

[kivikakk]

I like this very much! Can you clarify the bit about the macOS build? I tried it locally (with -Dsystem_library=false) and it tested fine, and it looks OK in CI too. Similarly, using that commit with koino seems fine on my system.

[lun-4]

had a temporary hack to make pcre work on my system and that broke macos (as well as ubuntu, it seems), but now it works out without issues so I'll leave it as false by default

looks like windows cross-compiles as well: tested with zig build -Dtarget=x86_64-windows-gnu -Doptimize=ReleaseSafe -Dcpu=x86_64_v2 -Dsystem_library=false, I wonder if that would close #17 by accident 🤔

[kivikakk]

but now it works out without issues so I'll leave it as false by default

SGTM! I pushed a commit with a typo fix so you might need to pull.

I wonder if that would close #17 by accident 🤔

!!! Heyooo. I don't have a Windows dev machine right now but I'll try it in CI …

[lun-4]

I think this would also kind of remove the need to vendor the library at this rate. if someone wants to use linkPcre they would be able to add .{ .system_library = "true" } to b.dependency()'s args. if you agree with this I can update the readme accordingly (and signal that windows is not supported in that mode)

[kivikakk]

if you agree with this I can update the readme accordingly (and signal that windows is not supported in that mode)

Yes, absolutely! I'm really pleased with this, thanks so much for pushing all your work up!

[kivikakk]

Windows success! :)

[lun-4]

ready to merge as soon as CI passes again!

[kivikakk]

Tysm! <3

[kivikakk]

I'll make the koino update now and save you the extra work!