Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both
unescape
andltrim
were doing exponential work based on the number of matches in the input, by callingremove
repeatedly, thus re-copying the same tail of the vector.Surprisingly, I don't see a better safe tool for this than
rotate_left
offhand, which is a recently-stabilized API (and still isn't really the right tool), so I wrote some unsafe code, and only tested it lightly.cc @SSJohns