Don't copy ~every input string if we can avoid it. #629
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out
process_linewill pretty much duplicate every line fed to it — we avoid including the actual line ending character infeed, but thenprocess_linedemands its input ends in one!This results in a ~1.12x speed-up on the benchmark document. Yippee. Documents with CRLF line actually already ran about as fast — they get a more modest 1.05x speed-up.