Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing of tables nested in other block elements #61

Merged
merged 1 commit into from
Apr 30, 2018

Conversation

brson
Copy link
Collaborator

@brson brson commented Apr 26, 2018

The row parser was not scanning from the correct offset.

The row parser was not scanning from the correct offset.
Copy link
Owner

@kivikakk kivikakk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kivikakk
Copy link
Owner

I hope this is okay with you — I've added you as a collaborator and marked master as protected, so you can merge yourself after review.

@kivikakk
Copy link
Owner

In fact, I've revised my decision: feel free to merge without a review first if you're confident. (And this is a pretty clear example of something to be confident about.) I'm a big fan of Peter Hintjens' "optimistic merging" idea.

@kivikakk kivikakk merged commit 4b2d20d into kivikakk:master Apr 30, 2018
@brson
Copy link
Collaborator Author

brson commented Apr 30, 2018

Thanks @kivikakk :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants