chore: update vue to latest version of vue2#4130
Closed
eddieferrer wants to merge 1 commit intomainfrom
Closed
Conversation
dyersituations
approved these changes
Aug 22, 2022
eddieferrer
force-pushed
the
upgrade_vue
branch
from
77bdbdc to
4d36a9a
Compare
eddieferrer
requested review from
christian14b,
edwinf-barreram,
egoroza,
emuvente,
mcstover,
roger-in-kiva and
tiarascoleman
mcstover
reviewed
Aug 22, 2022
mcstover
reviewed
Aug 22, 2022
Collaborator
|
@eddieferrer Does |
Contributor
Author
|
I can't merge this in because of our unit testing. vue-test-utils: vuejs/vue-test-utils#1983 |
Contributor
Author
Yep, added |
eddieferrer
force-pushed
the
upgrade_vue
branch
from
4d36a9a to
70fe016
Compare
Contributor
Author
|
Closing this, see links above ^ |
Collaborator
|
Maybe they'll get it cleaned up in a week or so. There had been at least some activity there |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade vue to latest 2.x version.
Tons of bug fixes in the release notes, and most of the vue3 features backported.
There is a warning: "[@vue/compiler-sfc] ::v-deep usage as a combinator has been deprecated. Use :deep() instead." on build. I can clean that up in a followup PR