Skip to content
This repository has been archived by the owner on Jan 11, 2019. It is now read-only.

[email protected] breaks build 🚨 #46

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

greenkeeperio-bot
Copy link
Contributor

Hello lovely humans,

jsdom just published its new version 9.9.1.

State Failing tests 🚨
Dependency jsdom
New version 9.9.1
Type devDependency

This version is covered by your current version range and after updating it in your project the build went from success to failure.

As jsdom is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Of course this could just be a false positive, caused by a flaky test suite, or third parties that are currently broken or unavailable, but that would be another problem I’d recommend working on.

Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right?
Are you unsure about how things are supposed to work?

There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.

Good luck with your project ✨

You rock!

🌴


The new version differs by 46 commits .

  • 5f949cf Version 9.9.1
  • 7c2861d Don't use .includes yet
  • 05e0c53 Version 9.9.0
  • fedc336 Add CDATA sections
  • 30f7906 Add document.embeds, plugins, and scripts
  • 5261738 Implement document.title correctly per-spec
  • ae19887 Implement document.body correctly per-spec
  • 656f606 Add more selector tests
  • bb12085 Fix CORS POST JSON XHRs with Authorization
  • 8bb591d Fix EventListener once handling
  • 45f4458 Add Node's wholeText property
  • 3c50533 Only log "not implemented" errors if form submission isn't canceled
  • 60555c0 Allow insertAdjacentHTML without a parent element sometimes
  • 139b9d7 Upgrade whatwg-url dependency to 4.1.0
  • 4c40a11 Fix a README typo

There are 46 commits in total. See the full diff.


This pull request was created by greenkeeper.io.

Tired of seeing this sponsor message? ⚡ greenkeeper upgrade

@CLAassistant
Copy link

CLAassistant commented Dec 19, 2016

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 76.863% when pulling f9649e9 on greenkeeper-jsdom-9.9.1 into 1f7cb49 on master.

@kitten kitten force-pushed the master branch 2 times, most recently from 3732111 to e5a733a Compare February 7, 2017 19:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants