Skip to content

Commit

Permalink
Don't export unused wide prop from GenericSlider. The $$Props type de…
Browse files Browse the repository at this point in the history
…fintiion is enough.
  • Loading branch information
kitschpatrol committed May 31, 2024
1 parent ee0fe00 commit 758adad
Showing 1 changed file with 5 additions and 8 deletions.
13 changes: 5 additions & 8 deletions src/lib/internal/GenericSlider.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -65,14 +65,11 @@
export let format: $$Props['format'] = undefined;
export let ref: $$Props['ref'] = undefined;
// Wide is "patched in" to address issue #8
// Wheel and Ring, which extend GenericSlider, which have an internal wide prop,
// were also modified to share this interface
// to inherit the wide prop.
export let wide: $$Props['wide'] = undefined;
// This prop is only used by children, but this appeases the compiler
wide = wide;
// Wide is "patched in" to address issue #8. Wheel and Ring, which extend
// GenericSlider, already have an implementation for a wide prop, so they
// share this interface. Doesn't actually need to be exported because
// it's only used by components that inherit from GenericSlider.
// export let wide: $$Props['wide'] = undefined;
// Deal with format firing a change firing even when the function hasn't changed probably
// related to https://github.com/sveltejs/svelte/issues/4265 possibly fixable with
Expand Down

0 comments on commit 758adad

Please sign in to comment.