forked from nicojs/typed-html
-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for jsx-runtime #129
Merged
Merged
Changes from 1 commit
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
461742f
feat: add support for jsx-runtime
JacopoPatroclo 2284dfc
docs: update with example using tsconfig jsxImportSource
JacopoPatroclo 749debb
feat: jsx-runtime
arthurfiorette 9115c4b
style: formatted code
arthurfiorette c79676a
chore: jsx benchmark
arthurfiorette 2a41a44
sty
arthurfiorette 30016a6
code
arthurfiorette 8483e53
fix tests
arthurfiorette 316b232
fix bench
arthurfiorette 1340015
doc: update readme to be react-jsx first
JacopoPatroclo eabb7fa
doc: update jsdocs for jsx and jsxs functions
JacopoPatroclo 1e540f5
doc: add deprecation warning message to the top of the register file,…
JacopoPatroclo 4d9cb00
doc: add serialization table in the readme file, update tests to be c…
JacopoPatroclo aaf7d9f
feat: improved jsx and createElement
arthurfiorette 6419d25
deps: updated dependencies and benchmark
arthurfiorette 2415990
feat: updates
arthurfiorette 5b87e85
feat: added more serialization examples
arthurfiorette b7c1919
lockfile
arthurfiorette fc3c1b8
feat: migrate tests to use jsx-runtime by default
JacopoPatroclo c659145
doc: fix typo in output table
JacopoPatroclo 799f392
fix: refactor project to be a pnpm workspace, refactor benchmarsk to …
JacopoPatroclo ad0f79f
initial monorepo with changesets
arthurfiorette c7f369d
changeset
arthurfiorette e4b3d27
nvm
arthurfiorette 11c8307
feat: ts-html-plugin
arthurfiorette 3d05717
feat: fastify-html-plugin
arthurfiorette a4d64c3
feat: removed MdnHomepage to a real world scenario
arthurfiorette 2c75b94
feat: added notes regarding benchmarks
arthurfiorette bba98e2
docs: updated package json links
arthurfiorette d38983e
test: 100% coverage
arthurfiorette 8eadee3
doc: fix grammar on benchmark readme, add reference to it on the root…
JacopoPatroclo 932a955
feat: reserved key atttribute
arthurfiorette cc76ff7
feat: avoid hijacking reply
arthurfiorette 73a07f1
code
arthurfiorette 67ac1d2
packagejson
arthurfiorette c00efaf
ci
arthurfiorette 9f35b92
lockfile
arthurfiorette b3732c2
ci
arthurfiorette b611195
vscode
arthurfiorette a9a765e
ts-html-plugin: solve path resolution issue on tests, add debug file …
JacopoPatroclo 26fe409
refactor: renamed testing env var to a more descriptive one
arthurfiorette 1d96f49
fix: test inconsistencies
arthurfiorette aa8973d
merge: merge main
arthurfiorette 7a51612
chore: declaration maps for benchmarks
arthurfiorette f4656f4
chore: changeset
arthurfiorette File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,3 +4,5 @@ node_modules | |
index.tsbuildinfo | ||
dist | ||
coverage | ||
|
||
*.log |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arthurfiorette I'm not sure about this, empty Objects are no longer supported by
kitajs/html
, right? Should we live this line by adding an expected ts error or should we, as I did, remove the line completely?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, but the error thrown in this line is not from the ts-html-plugin and just a type error from typescript.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, that's correct. So we should not test this behavior. I'll leave it like this.