fix: correct content-length value

kitajs · May 27, 2024 · 715205a · 715205a
1 parent 3c578f6
commit 715205a
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/.changeset/tough-waves-float.md b/.changeset/tough-waves-float.md
@@ -0,0 +1,5 @@
+---
+'@kitajs/fastify-html-plugin': patch
+---
+
+Correct content-length value
diff --git a/packages/fastify-html-plugin/index.js b/packages/fastify-html-plugin/index.js
@@ -17,7 +17,7 @@ const kAutoDoctype = Symbol.for('fastify-kita-html.autoDoctype');
  * >}
  */
 function plugin(fastify, opts, next) {
-  fastify.decorateReply(kAutoDoctype, (opts.autoDoctype ??= true));
+  fastify.decorateReply(kAutoDoctype, opts.autoDoctype ?? true);
   fastify.decorateReply('html', html);
   return next();
 }
@@ -63,12 +63,9 @@ function handleHtml(htmlStr, reply) {
   const requestData = SUSPENSE_ROOT.requests.get(reply.request.id);
 
   if (requestData === undefined) {
-    return (
-      reply
-        // Should be safe to use .length instead of Buffer.byteLength here
-        .header('content-length', handleHtml.length)
-        .send(htmlStr)
-    );
+    return reply
+      .header('content-length', Buffer.byteLength(htmlStr, 'utf-8'))
+      .send(htmlStr);
   }
 
   requestData.stream.push(htmlStr);