Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from Travis CI to GitHub Actions #64

Merged
merged 2 commits into from
Jul 7, 2024

Conversation

navytux
Copy link
Collaborator

@navytux navytux commented Jul 7, 2024

Hello @kisielk.

I need to refresh and improve ogórek a bit. Before doing so let's first restore CI to working state. Please see individual patches for details.

Thanks beforehand,
Kirill

navytux added 2 commits July 7, 2024 16:49
Travis CI no longer works for ogórek and https://travis-ci.org/kisielk/og-rek
returns "not found".

-> Switch to GitHub Actions to fix CI.

We loose CI coverage for "go tip" as specifying "tip" Go version in
actions/setup-go is not supported out of the box:

actions/setup-go#21

Maybe in 201x it was relevant to test wrt go tip, but nowdays I think
this is no longer much needed.
Add CI coverage for all releases past go1.15 that we had before.
@navytux
Copy link
Collaborator Author

navytux commented Jul 7, 2024

(results of actions run for this PR are here: https://github.com/navytux/og-rek/actions/runs/9827823225)

Copy link
Owner

@kisielk kisielk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@kisielk kisielk merged commit 72a53b6 into kisielk:master Jul 7, 2024
@navytux
Copy link
Collaborator Author

navytux commented Jul 7, 2024

Kamil, thanks for prompt response merging.

@navytux navytux deleted the y/github-actions branch July 7, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants