README: Suggest go get -u by default. #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suggesting `go get -u` is a safer default. It results in a more predictable action, the user will end up with the latest version of `errcheck` and all its dependencies. Otherwise, the versions users end up with will be arbitrary, which may lead to issues. If users prefer not to update dependencies, they can always `go get` without `-u` flag. As an example of the issue this would help resolve, see #92.
kisielk
added a commit
that referenced
this pull request
Feb 18, 2016
README: Suggest go get -u by default.
|
Good idea. Hopefully that clears up some confusion :) |
|
Sorry, GitHub notifications are a total mess for me so I didn't see the incoming PR first time around. I didn't even get the @ notice this time... |
|
Heh, just now I got the notification for the @ mention, thanks GitHub. |
|
That's surprising, you're watching this repo so I expected you to get a notification. Thanks for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggesting
go get -uis a safer default. It results in a more predictable action, the user will end up with the latest version oferrcheckand all its dependencies. Otherwise, the versions users end up with will be arbitrary, which may lead to issues. If users prefer not to update dependencies, they can alwaysgo getwithout-uflag.As an example of the issue this would help resolve, see #92.