feat: KeyboardToolbar.Exclude
#881
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirillzyusko
added
enhancement
kirillzyusko
force-pushed
the
feat/keyboard-toolbar-exclude
branch
from
0c409b6 to
cf36b65
Compare
|
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
📊 Package size report
|
|
A slightly better approach would be to introduce a component: <KeyboardToolbar.Group name="group1" discoverable>
</KeyboardToolbar.Group>In this what effectively we would do is to split inputs in group under their own names. Such approach is more flexible in my inderstanding, because if we would have tab-view written in pure JS:
Then we in last input of tab 1 we could easily go to the second tab. If we would use I think a new API should offer better extendability for future goals. |
| if (isValidTextInput(child)) { | ||
| result = child as EditText | ||
| } else if (child is ViewGroup) { | ||
| } else if (child is ViewGroup && child !is KeyboardToolbarExcludeReactViewGroup) { |
There was a problem hiding this comment.
this check repeats twice, would it be better to use helper function for this?
| return validTextInput | ||
| } | ||
|
|
||
| guard String(describing: type(of: view)) != "KeyboardToolbarExcludeView" else { return nil } |
There was a problem hiding this comment.
- is it possible to use instance check instead of comparing two strings?
- it repeats twice
There was a problem hiding this comment.
Copilot reviewed 6 out of 16 changed files in this pull request and generated 1 comment.
Files not reviewed (10)
- android/src/base/java/com/reactnativekeyboardcontroller/KeyboardControllerPackage.kt: Language not supported
- android/src/main/java/com/reactnativekeyboardcontroller/managers/KeyboardToolbarExcludeViewManagerImpl.kt: Language not supported
- android/src/main/java/com/reactnativekeyboardcontroller/traversal/ViewHierarchyNavigator.kt: Language not supported
- android/src/main/java/com/reactnativekeyboardcontroller/views/KeyboardToolbarExcludeReactViewGroup.kt: Language not supported
- android/src/paper/java/com/reactnativekeyboardcontroller/KeyboardToolbarExcludeViewManager.kt: Language not supported
- android/src/turbo/java/com/reactnativekeyboardcontroller/KeyboardControllerPackage.kt: Language not supported
- docs/docs/api/components/keyboard-toolbar/index.mdx: Language not supported
- ios/traversal/ViewHierarchyNavigator.swift: Language not supported
- ios/views/KeyboardToolbarExcludeViewManager.h: Language not supported
- ios/views/KeyboardToolbarExcludeViewManager.mm: Language not supported
| : ({ children }: KeyboardGestureAreaProps) => children; | ||
| export const RCTOverKeyboardView: React.FC<OverKeyboardViewProps> = | ||
| require("./specs/OverKeyboardViewNativeComponent").default; | ||
| export const RCTKeyboardToolbarExcludeView: React.FC<OverKeyboardViewProps> = |
There was a problem hiding this comment.
The type for RCTKeyboardToolbarExcludeView should use KeyboardToolbarExcludeViewProps instead of OverKeyboardViewProps for consistency with the rest of the bindings.
Suggested change
| export const RCTKeyboardToolbarExcludeView: React.FC<OverKeyboardViewProps> = | |
| export const RCTKeyboardToolbarExcludeView: React.FC<KeyboardToolbarExcludeViewProps> = |
Copilot uses AI. Check for mistakes.
2 tasks
kirillzyusko
added a commit
that referenced
this pull request
Sep 23, 2025
## 📜 Description Added compound pattern to `KeyboardToolbar` component. ## 💡 Motivation and Context This component started as a very simple component with limited customization. However, over the time it got many new props, such as `onNextCallback` etc. and right now we have too many props for customization. Since I'm planning to add #881 I decided that it'll be a good time to refactor the component and apply compound pattern. So in the end I come up with next API design: ```tsx <KeyboardToolbar> <KeyboardToolbar.Background /> <KeyboardToolbar.Prev /> <KeyboardToolbar.Next /> <KeyboardToolbar.Content /> <KeyboardToolbar.Done /> </KeyboardToolbar> ``` > I intentionally changed `blur` prop to `background`, because with iOS 26 we may use liquid glass as a container Closes #1121 ## 📢 Changelog <!-- High level overview of important changes --> <!-- For example: fixed status bar manipulation; added new types declarations; --> <!-- If your changes don't affect one of platform/language below - then remove this platform/language --> ### JS - added new compound `KeyboardToolbar` API; - moved props declaration into `types.ts` file. ### Docs - added new API reference; - added migration guide. ## 🤔 How Has This Been Tested? - tested that old code works with new API and doesn't introduce visual regressions (via e2e tests) - started to use new API and assure that it doesn't break e2e tests. ## 📸 Screenshots (if appropriate): <img width="614" height="422" alt="image" src="https://github.com/user-attachments/assets/8d2cc932-7fd8-4f29-89d4-bf4961bd97dc" /> ## 📝 Checklist - [x] CI successfully passed - [x] I added new mocks and corresponding unit-tests if library API was changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
💡 Motivation and Context
Closes #470
📢 Changelog
JS
iOS
Android
🤔 How Has This Been Tested?
📸 Screenshots (if appropriate):
📝 Checklist