Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use contentInset for KeyboardAwareScrollView #797

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: use contentInset for KeyboardAwareScrollView #797

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions src/components/KeyboardAwareScrollView/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@ import { findNodeHandle } from "react-native";
import Reanimated, {
interpolate,
scrollTo,
useAnimatedProps,
useAnimatedReaction,
useAnimatedRef,
useAnimatedStyle,
useScrollViewOffset,
useSharedValue,
} from "react-native-reanimated";
Expand Down Expand Up @@ -359,17 +359,19 @@ const KeyboardAwareScrollView = forwardRef<
[],
);

const view = useAnimatedStyle(
const view = useAnimatedProps(
() =>
enabled
? {
// animations become choppy when scrolling to the end of the `ScrollView` (when the last input is focused)
// this happens because the layout recalculates on every frame. To avoid this we slightly increase padding
// by `+1`. In this way we assure, that `scrollTo` will never scroll to the end, because it uses interpolation
// from 0 to `keyboardHeight`, and here our padding is `keyboardHeight + 1`. It allows us not to re-run layout
// re-calculation on every animation frame and it helps to achieve smooth animation.
// see: https://github.com/kirillzyusko/react-native-keyboard-controller/pull/342
paddingBottom: currentKeyboardFrameHeight.value + 1,
contentInset: {
// animations become choppy when scrolling to the end of the `ScrollView` (when the last input is focused)
// this happens because the layout recalculates on every frame. To avoid this we slightly increase padding
// by `+1`. In this way we assure, that `scrollTo` will never scroll to the end, because it uses interpolation
// from 0 to `keyboardHeight`, and here our padding is `keyboardHeight + 1`. It allows us not to re-run layout
// re-calculation on every animation frame and it helps to achieve smooth animation.
// see: https://github.com/kirillzyusko/react-native-keyboard-controller/pull/342
bottom: currentKeyboardFrameHeight.value + 1,
},
}
: {},
[enabled],
Expand All @@ -379,11 +381,11 @@ const KeyboardAwareScrollView = forwardRef<
<ScrollViewComponent
ref={onRef}
{...rest}
animatedProps={view}
scrollEventThrottle={16}
onLayout={onScrollViewLayout}
>
{children}
<Reanimated.View style={view} />
</ScrollViewComponent>
);
},
Expand Down
Loading