Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hide sensitive values not working #16

Open
iamwinq opened this issue Jan 20, 2023 · 10 comments
Open

hide sensitive values not working #16

iamwinq opened this issue Jan 20, 2023 · 10 comments
Labels
ARDU bug Something isn't working

Comments

@iamwinq
Copy link

iamwinq commented Jan 20, 2023

feature to hide sensitive info like gps, altitude and distance does not seem to work in my testing, ardupilot setup by the way..
osd

@kirek007 kirek007 added bug Something isn't working ARDU labels Jan 20, 2023
@kirek007
Copy link
Owner

Can you provide OSD file? Looks like Ardupilot is using a different icon id, that's why it doesn't work

@keithluneau
Copy link

Here's a short video, osd, and srt files from the end of my last flight. It's Ardupilot plane firmware. Hopefully this helps! https://drive.google.com/file/d/1s8FFXXZor7RdorVWQqW20dhkVUXKITuI/view?usp=share_link

@iamwinq
Copy link
Author

iamwinq commented Jan 21, 2023

@iamwinq
Copy link
Author

iamwinq commented Jan 21, 2023

i also tried rendering keith's video, with Hide sensitive data enabled, yet it still shows alt and distance
image

@kirek007
Copy link
Owner

kirek007 commented Jan 21, 2023 via email

@iamwinq
Copy link
Author

iamwinq commented Jan 22, 2023

Hey guys, looks like hiding data works only for INAV and only for GPS and home distance. I'll try to make it works for ARDU too in the next version ;) W dniu sob., 21.01.2023 o 02:46 iamwinq @.> napisał(a):

i also tried rendering keith's video, with Hide sensitive data enabled, yet it still shows alt and distance [image: image] https://user-images.githubusercontent.com/95698959/213835504-253a2f8a-b0a9-40e8-83fc-9e5d2ffbb2ab.png — Reply to this email directly, view it on GitHub <#16 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOKQC5P3O2QOZWPXUAVSBLWTM5YZANCNFSM6AAAAAAUBW2CQQ . You are receiving this because you commented.Message ID: @.
>

thanks again! Looking forward to it ;)

@endymuhardin
Copy link
Contributor

It's not working with Betaflight either. The only thing it hides is the throttle value :D
GPS Coordinate and Altitude is still showing.

@kirek007
Copy link
Owner

kirek007 commented Feb 10, 2023 via email

@WereWolfPL
Copy link

I don't know how osd data are structured and if it's possible, but it would be nice (in the future) to be able to select which data yout want to hide (or what data you want to display) in the generated files. Maybe it's an overkill but why not :)

@avsaase
Copy link

avsaase commented Feb 10, 2023

It would be nice if the user can supply the grid cells that they want to mask. That way the user can determine from themselves what they consider sensitive and you don't have to rely on detecting specific OSD element in the .osd files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARDU bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants