Remote Start / Stop using RFID #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fekberg you might want to reformat your code to please the tests :-) |
jschlyter
reviewed
Dec 1, 2023
|
Update Python module (v1.6.0) released. |
jschlyter
reviewed
Dec 1, 2023
| description: > | ||
| The number of bytes the RFID tag used | ||
| example: 4 | ||
| rfid_format: |
There was a problem hiding this comment.
Perhaps this should be an enum?
There was a problem hiding this comment.
@fekberg please check this as well and I'll merge again.
There was a problem hiding this comment.
@jschlyter Could you elaborate what you mean here? Not entirely sure where the enum would be useful in the services.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires the code from my other PR first.