Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mypy not detect pytest in dev ci #42

Merged
merged 1 commit into from
Aug 2, 2024
Merged

fix mypy not detect pytest in dev ci #42

merged 1 commit into from
Aug 2, 2024

Conversation

kiraware
Copy link
Owner

@kiraware kiraware commented Aug 2, 2024

mypy require pytest (test dependency) to be installed in order to perform static type analysis, hence it raise error if pytest dependency not installed. to fix this, we just need to include the test dependency.

mypy require pytest (test dependency) to be installed in order to
perform static type analysis, hence it raise error if pytest dependency
not installed. to fix this, we just need to include the test dependency.
@kiraware kiraware added bug Something isn't working github_actions Pull requests that update GitHub Actions code labels Aug 2, 2024
@kiraware kiraware requested a review from vexra August 2, 2024 03:42
@kiraware kiraware self-assigned this Aug 2, 2024
Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (f3dc004) to head (bbd145d).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #42   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines          575       575           
=========================================
  Hits           575       575           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vexra vexra merged commit bd6e206 into main Aug 2, 2024
11 checks passed
@vexra vexra deleted the fix-dev-ci-mypy branch August 2, 2024 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants